Skip to content

⚡️ Speed up function check_formatter_installed by 22% in PR #1199 (omni-java) #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
claude merged 2 commits into from
Feb 21, 2026
Merged

⚡️ Speed up function check_formatter_installed by 22% in PR #1199 (omni-java) #1622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ff58f0
Optimize check_formatter_installed
codeflash-ai[bot] Feb 20, 2026
f09c471
style: auto-fix linting issues
github-actions[bot] Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion codeflash/code_utils/env_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,11 @@ def check_formatter_installed(
if not formatter_cmds or formatter_cmds[0] == "disabled":
return True
first_cmd = formatter_cmds[0]
cmd_tokens = shlex.split(first_cmd) if isinstance(first_cmd, str) else [first_cmd]
# Fast path: avoid expensive shlex.split for simple strings without quotes
if " " not in first_cmd or ('"' not in first_cmd and "'" not in first_cmd):
cmd_tokens = first_cmd.split()
else:
cmd_tokens = shlex.split(first_cmd)

if not cmd_tokens:
return True
Expand Down
1 change: 0 additions & 1 deletion codeflash/languages/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
reset_current_language,
set_current_language,
)

from codeflash.languages.registry import (
detect_project_language,
get_language_support,
Expand Down
2 changes: 1 addition & 1 deletion codeflash/languages/registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def _ensure_languages_registered() -> None:
from codeflash.languages.python import support as _

with contextlib.suppress(ImportError):
from codeflash.languages.javascript import support as _ # noqa: F401
from codeflash.languages.javascript import support as _

with contextlib.suppress(ImportError):
from codeflash.languages.java import support as _ # noqa: F401
Expand Down
Loading