Skip to content

Add export compliance flow and review submission detail page#13

Merged
trmquang93 merged 3 commits intomainfrom
feature/export-compliance-ui
Apr 8, 2026
Merged

Add export compliance flow and review submission detail page#13
trmquang93 merged 3 commits intomainfrom
feature/export-compliance-ui

Conversation

@trmquang93
Copy link
Copy Markdown
Contributor

Summary

  • Rewrite export compliance to use the correct ASC API flow (appStoreVersion -> build -> buildBundles -> buildBundleFileSizes for ECCN/encryption declarations)
  • Add review submission detail page at /app/:id/review/:submissionId with deep linking, back navigation, and clickable review rows
  • Clean up backend review detail endpoint to use a single API call instead of parallel fetch + merge with debug logs

Test plan

  • Verify export compliance section loads correctly on version detail page
  • Click a review submission row (messages or submissions) and confirm navigation to detail page
  • Verify deep linking works by directly visiting /app/:id/review/:submissionId
  • Test browser back button returns to the app detail page
  • Confirm review detail shows correct state, dates, submitted by, and item states

- Surface compliance status in BuildSelector for all builds, not just
  when compliance is missing (always show Edit/Manage button)
- Enrich attached build with complianceState from builds list
- Remove deprecated usesNonExemptEncryption from declaration API calls
- Rewrite PATCH handler to use correct ASC API approach:
  - "No encryption": PATCH build with usesNonExemptEncryption=false
  - "Yes + algorithm": POST new declaration, then PATCH build to link it
- Include usesNonExemptEncryption in build fields and derive compliance
  state as VALID when explicitly set to false
- Add ReviewSubmissionDetail component showing submission state, dates, actors, and item states
- Wire up URL routing for /app/:id/review/:submissionId with deep linking and back navigation
- Make review submission rows clickable in AppReviewSection to navigate to detail view
- Add fetchReviewSubmissionDetail API client function
- Clean up backend endpoint to use single API call instead of parallel fetch with merge
- Export formatDate and ReviewStatus from AppReviewSection for reuse
…ance-ui

# Conflicts:
#	server/routes/apps.js
@trmquang93 trmquang93 merged commit 0fa5e01 into main Apr 8, 2026
@github-actions github-actions bot deleted the feature/export-compliance-ui branch April 8, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant