Skip to content

Fix Bill History Scraper #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ACoullard wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −10
Open

Fix Bill History Scraper #2123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc60a2e
allow date to be nullable on billHistory items
ACoullard May 7, 2026
bea930c
formatting
ACoullard May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/bill/HistoryTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const BillHistoryActionRows = ({ billHistory }: HistoryProps) => {
return (
<tr key={index}>
<td>
{Date.substring(5, 10)}-{Date.substring(0, 4)}
{Date ? `${Date.substring(5, 10)}-${Date.substring(0, 4)}` : ""}
</td>
<td>
<LinkConnectedBills action={Action} />
Expand Down
10 changes: 2 additions & 8 deletions components/bill/Status.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,8 @@ export const Status = ({ bill }: BillProps) => {
hearingCheck = true
}

let hearingDate = ""
if (history?.Date) {
hearingDate = history.Date
}
let dateCheck = false
if (hearingDate < today) {
dateCheck = true
}
const hearingDate = history?.Date ?? ""
const dateCheck = !!hearingDate && hearingDate < today

if (!history) return null
return (
Expand Down
2 changes: 1 addition & 1 deletion functions/src/bills/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export const BillReference = Record({

export type BillHistoryAction = Static<typeof BillHistoryAction>
export const BillHistoryAction = Record({
Date: String,
Date: Nullable(String),
Branch: String,
Action: String
})
Expand Down
Loading