Conversation
| name: subteamName, | ||
| }; | ||
|
|
||
| // @ts-ignore |
There was a problem hiding this comment.
Typescript is unable to find methods that have been patched in. If it sees a method like createSubteam that doesn't come with the keybase-bot npm package, it will error and not run.
| .addMembers({ | ||
| team: subteamName, | ||
| usernames: usernamesToAdd, | ||
| usernames: usernamesToAdd as AddMemberUsernameItem[], |
There was a problem hiding this comment.
team.addMembers() is looking for a usernames object with type AddMemberUsernameItem[]. Because usernamesToAdd is defaulting to an object[], it's erroring. So we cast object[] to AddMemberUsernameItem[].
| - MongoDB (if you're running the bot locally) | ||
| - Unix/Linux Server - Croupier relies on non-Windows commands (namely `which`) | ||
| - `expect` command (`apt-get install expect`) | ||
| - Some Lumens to fund the bot accounts (Main bot needs at least 1XLM to function) |
There was a problem hiding this comment.
Main bot needs at least 2.01XLM
| ### Requirements | ||
|
|
||
| - MongoDB (if you're running the bot locally) | ||
| - Unix/Linux Server - Croupier relies on non-Windows commands (namely `which`) |
There was a problem hiding this comment.
macOS, Linux, or Windows Subsystem for Linux – Croupier relies on non-Windows commands such as which
| import * as os from "os"; | ||
| import * as throttledQueue from "throttled-queue"; | ||
| import * as Bot from "./keybase-bot"; | ||
| // @ts-ignore |
There was a problem hiding this comment.
There are a lot of these @ts-ignore comments. They seem to be cluttering the code now – is there a deeper fix?
| process.env.MONGODB_PASSWORD, | ||
| process.env.MONGODB_HOST, | ||
| true, | ||
| JSON.parse(process.env.IS_CLUSTER), |
There was a problem hiding this comment.
If we're now coding this as an envvar, we should remove the isCluster param from the class Croupier constructor(), and just have the constructor method check JSON.parse(process.env.IS_CLUSTER).
zackster
left a comment
zackster
left a comment
There was a problem hiding this comment.
Looks good. Left some comments that I'd like you to address. Finally, and at some point this should be automated, once the comments are addressed, could you please confirm that you ran the end to end test suite as described in the README?
2 participants
#35 Finished