-
Notifications
You must be signed in to change notification settings - Fork 37
refactor(security): extract secrets detection into dedicated shell script #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Artem-Zahumonnyi
wants to merge
2
commits into
codemie-ai:main
Choose a base branch
from
Artem-Zahumonnyi:epmcdme-10997-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,28 +1,3 @@ | ||
| # Run lint-staged (lint + test changed files) | ||
| npx lint-staged | ||
|
|
||
| # Check for secrets (only if Docker daemon is running) | ||
| if command -v docker >/dev/null 2>&1 && docker info >/dev/null 2>&1; then | ||
| echo "🔍 Checking for secrets with Gitleaks..." | ||
| npm run validate:secrets || { | ||
| echo "⚠️ Secrets detected! Please remove sensitive data before committing." | ||
| exit 1 | ||
| } | ||
| else | ||
| # Docker not available - provide helpful hints based on installed alternatives | ||
| if command -v colima >/dev/null 2>&1; then | ||
| echo "⚠️ Docker daemon not running - Colima is installed" | ||
| echo "💡 Run 'colima start' to enable secrets detection locally" | ||
| elif command -v podman >/dev/null 2>&1; then | ||
| echo "⚠️ Docker daemon not running - Podman is installed" | ||
| echo "💡 Run 'podman machine start' to enable secrets detection locally" | ||
| elif command -v orbstack >/dev/null 2>&1; then | ||
| echo "⚠️ Docker daemon not running - OrbStack is installed" | ||
| echo "💡 Start OrbStack to enable secrets detection locally" | ||
| elif command -v docker >/dev/null 2>&1; then | ||
| echo "⚠️ Docker installed but daemon not running" | ||
| echo "💡 Start Docker Desktop to enable secrets detection locally" | ||
| else | ||
| echo "⚠️ Docker not available - skipping secrets detection (will run in CI)" | ||
| fi | ||
| fi | ||
| npm run validate:secrets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| #!/usr/bin/env bash | ||
| # Secrets detection using Gitleaks via Docker or Podman. | ||
| # Usage: | ||
| # scripts/secrets-check.sh # scan staged files | ||
| # scripts/secrets-check.sh --git # scan full git history | ||
|
|
||
| GITLEAKS_IMAGE="ghcr.io/gitleaks/gitleaks:v8.30.1" | ||
| CONTAINER_ENGINE=$(command -v docker 2>/dev/null || command -v podman 2>/dev/null) | ||
|
|
||
| if [[ -z "$CONTAINER_ENGINE" ]]; then | ||
| echo "No suitable container engine found - skipping secrets detection" | ||
| echo "Install Docker to enable local secrets scanning" | ||
| exit 1 | ||
| fi | ||
|
|
||
| if ! $CONTAINER_ENGINE info >/dev/null 2>&1; then | ||
| if command -v colima >/dev/null 2>&1; then | ||
| echo "Docker daemon not running - Colima is installed" | ||
| echo "Run 'colima start' to enable secrets detection locally" | ||
| elif command -v podman >/dev/null 2>&1; then | ||
| echo "Docker daemon not running - Podman is installed" | ||
| echo "Run 'podman machine start' to enable secrets detection locally" | ||
| elif command -v orbstack >/dev/null 2>&1; then | ||
| echo "Docker daemon not running - OrbStack is installed" | ||
| echo "Start OrbStack to enable secrets detection locally" | ||
| else | ||
| echo "Container engine found but daemon is not running" | ||
| fi | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "Checking for secrets with Gitleaks..." | ||
|
|
||
| if [[ "$1" == "--git" ]]; then | ||
| $CONTAINER_ENGINE run --rm -v "$(pwd):/path" "$GITLEAKS_IMAGE" git --no-banner --verbose /path | ||
| else | ||
| $CONTAINER_ENGINE run --rm -v "$(pwd):/path" "$GITLEAKS_IMAGE" dir --no-banner --verbose /path | ||
| fi | ||
|
|
||
| if [[ $? -ne 0 ]]; then | ||
| echo "Secrets detected! Please remove sensitive data before committing." | ||
| exit 1 | ||
| fi |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we used node.js to be able to run it on both win and linux, can we stick to this approach for all repos?