Be robust against Firefox sometimes returning a zero-width rect #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sometimes occurs in Firefox when a codemirror view is invisible initially. The rect does have a usable height, but the width is zero. This causes a set of Infinity and NaN values later in the flow. Be more robust against that: default it to a sensible value.
Member
|
How about just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sometimes occurs in Firefox when a codemirror view is invisible initially. The rect does have a usable height, but the width is zero. This causes a set of Infinity and NaN values later in the flow.
Be more robust against that: default it to a sensible value.
I manually verified this fixes codemirror/dev#1642. Since this codeflow is only hit in a case where everything errors out later anyway I'm quite confident about this fix.