v3.0.0: Major improvements + new features#57
Merged
codenameakshay merged 16 commits intomainfrom Mar 10, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 143 out of 155 changed files in this pull request and generated 1 comment.
Files not reviewed (12)
- android/src/main/AndroidManifest.xml: Language not supported
- android/src/main/res/xml/wallpaper.xml: Language not supported
- example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/.cmake/api/v1/reply/codemodel-v2-bb5646173387af7ec5dc.json: Language not supported
- example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/.cmake/api/v1/reply/directory-.-Debug-f5ebdc15457944623624.json: Language not supported
- example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/.cmake/api/v1/reply/index-2025-04-14T11-41-39-0026.json: Language not supported
- example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/CMakeFiles/3.22.1-g37088a8/CMakeCCompiler.cmake: Language not supported
- example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/CMakeFiles/3.22.1-g37088a8/CMakeCXXCompiler.cmake: Language not supported
- example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/CMakeFiles/3.22.1-g37088a8/CMakeSystem.cmake: Language not supported
- example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/CMakeFiles/cmake.check_cache: Language not supported
- example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/CMakeFiles/rules.ninja: Language not supported
- example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/android_gradle_build.json: Language not supported
- example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/android_gradle_build_mini.json: Language not supported
Comments suppressed due to low confidence (2)
android/src/main/kotlin/com/codenameakshay/async_wallpaper/AsyncWallpaperPlugin.kt:63
- Consider cancelling the coroutineScope (e.g., invoking coroutineScope.cancel()) when detaching the plugin to prevent potential memory leaks.
override fun onDetachedFromEngine(@NonNull binding: FlutterPlugin.FlutterPluginBinding) {
android/src/main/java/com/codenameakshay/async_wallpaper/VideoLiveWallpaper.java:121
- [nitpick] For consistency, consider using a dedicated TAG constant for logging throughout VideoLiveWallpaper.java instead of hard-coded strings like "VideoEngine" and "VideoLiveWallpaper".
Log.e("VideoEngine", "Error updating playback settings", e);
…LiveWallpaper.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
Very nice I also suggest upgrading the gradle version to above gradle-8.2.1 because of some deprecation errors in the new Flutter version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to the Android project, focusing on dependency upgrades, permission adjustments, and new features for battery management in the
VideoLiveWallpaperservice. The most important changes include upgrading the Android Gradle plugin, modifying permissions in the manifest, and implementing battery-aware playback settings.Dependency and build script updates:
android/build.gradle: Upgraded the Android Gradle plugin from version 7.2.0 to 7.4.2.example/android/app/build.gradle: Applied new plugins for Android application and Kotlin, updated Java version compatibility, and added new dependencies for desugaring and multidex support. [1] [2] [3] [4]example/android/build.gradle: Removed old buildscript and dependencies sections.Permission and manifest changes:
android/src/main/AndroidManifest.xml: Adjusted permissions for external storage withmaxSdkVersion, added new permissions for media access, and added a new service forVideoLiveWallpaper.Battery management and playback settings:
android/src/main/java/com/codenameakshay/async_wallpaper/VideoLiveWallpaper.java: Introduced battery management to adjust video playback settings based on battery level, including reducing frame rate and playback speed in low battery mode. [1] [2]These changes collectively enhance the application's performance, compatibility, and user experience, particularly in scenarios involving low battery conditions.