🤖 tests: migrate Coder stories to co-located component stories#3046
Open
🤖 tests: migrate Coder stories to co-located component stories#3046
Conversation
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate Coder Storybook coverage out of the app-level
App.coder.stories.tsxand into co-located component stories, removingAppWithMocksusage for this migration scope.Background
The previous Coder stories rendered the full app shell and relied on broad integration setup. This made the stories heavier than needed for runtime-selector and Coder form behavior coverage.
Implementation
src/browser/features/Runtime/CoderControls.stories.tsxwith component stories for:CoderWorkspaceFormstates (new/existing, parse errors, empty presets/workspaces, login header)CoderAvailabilityMessagestates (loading, outdated, unavailable-not-logged-in)src/browser/features/ChatInput/CreationControls.stories.tsxwith runtime-selector stories for:RuntimeButtonGroupandRuntimeButtonGroupPropsfromCreationControls.tsxso selector behavior can be tested directly at component scope.src/browser/stories/mocks/coder.ts.src/browser/stories/App.coder.stories.tsx.Validation
make typecheckmake lintmake static-check(blocked in this environment becausehadolintis not installed:bash: hadolint: command not found)static-checksubsteps successfully:make lintmake typecheckmake fmt-checkmake check-eager-importsmake check-code-docs-linksmake lint-shellcheckRisks
Low risk. Changes are limited to Storybook stories and fixture wiring, plus exporting an existing internal runtime-selector component without behavior changes.
Generated with
mux• Model:openai:gpt-5.3-codex• Thinking:xhigh• Cost:$10.26