⬆️ Bump flatted from 3.3.3 to 3.4.2#107
Conversation
Bumps [flatted](https://github.com/WebReflection/flatted) from 3.3.3 to 3.4.2. - [Commits](WebReflection/flatted@v3.3.3...v3.4.2) --- updated-dependencies: - dependency-name: flatted dependency-version: 3.4.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
averyjennings
left a comment
averyjennings
left a comment
There was a problem hiding this comment.
Verdict: request-changes
The PR title and description claim to bump flatted from 3.3.3 to 3.4.2 to fix CWE-1321 (prototype pollution), but the actual lockfile diff contains no changes to flatted at all.
What actually changed: get-tsconfig 4.13.0 → 4.13.6 (a transitive dep of the optional tsx package, which is itself pulled in by vitest).
Why this matters:
- If the intent is to apply the CWE-1321 security fix in
flatted, it hasn't landed. The lockfile shows noflattedversion bump. - Merging this as-is creates a misleading record that the prototype pollution vulnerability was addressed when it wasn't.
Suggested next steps:
- Run
grep flatted pnpm-lock.yaml— ifflatteddoesn't appear, it's no longer in the dependency graph and this advisory may be irrelevant. - If the update is genuinely needed, run
@dependabot recreateor manually pinflattedin the appropriate dependency.
The get-tsconfig side-effect bump is safe and benign on its own, but it shouldn't be merged under a misleading security framing.
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
|
@dependabot recreate |
|
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting |
|
Superseded by #124. |
2 participants
Bumps flatted from 3.3.3 to 3.4.2.
Commits
3bf09093.4.2885ddccfix CWE-13210bdba70added flatted-view to the benchmark2a02dce3.4.1fba4e8fMerge pull request #89 from WebReflection/python-fix5fe8648added "when in Rome" also a test for PHP53517adsome minor improvementb3e2a0cFixing recursion issue in Python tooc4b46dbAdd SECURITY.md for security policy and reportingf86d071Create dependabot.yml for version updatesYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.