Skip to content

Conversation

@code-snippets-bot
Copy link
Contributor

Release Preparation for v3.9.4

This pull request prepares the release for version v3.9.4.

Generated by:

  • Workflow: (Tag): Create a Tag Pull Request
  • Run: #172

Next steps:

  • Review the changelog entries
  • Verify version numbers are correct

@lightbulbman lightbulbman added the build Adding this label will trigger the zip build action label Jan 14, 2026
@lightbulbman
Copy link
Contributor

Testing the build for v3.9.4 feature * New import functionality to migrate snippets from file uploads with drag-and-drop interface* failed when importing a json either by manual upload or drag and drop. Error message shown is 500 server error with this detail:

"Uncaught TypeError: implode(): If argument #1 ($separator) is of type string, argument #2 ($array) must be of type array, null given in /code-snippets/php/migration/importers/files/file-upload-importer.php:283"

One other minor point the error message is shown at the bottom but the page doesn't scroll to bottom and I think this should be at the top

Screenshot 2026-01-14 at 09 57 41

fix: better handle null tags in snippet data
@imantsk
Copy link
Member

imantsk commented Jan 14, 2026

@lightbulbman

the parser was checking is_array( $snippet_data['tags'] ?? [] ) (which is always true when missing), then still calling implode() on $snippet_data['tags'] (null), causing the PHP fatal.
I’ve pushed a fix in #327 so missing/invalid tags safely imports as empty instead of crashing.
Could you retest with the latest build?

@imantsk imantsk added build Adding this label will trigger the zip build action and removed build Adding this label will trigger the zip build action labels Jan 14, 2026
@imantsk imantsk added build Adding this label will trigger the zip build action and removed build Adding this label will trigger the zip build action labels Jan 16, 2026
@lightbulbman lightbulbman added build Adding this label will trigger the zip build action and removed build Adding this label will trigger the zip build action labels Jan 16, 2026
@code-snippets-bot
Copy link
Contributor Author

code-snippets-bot commented Jan 16, 2026

Download and install

📦 code-snippets.3.9.4.zip

@lightbulbman lightbulbman merged commit 8ee0c5c into core Jan 16, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Adding this label will trigger the zip build action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants