Use serializer from createContextual as base deserializer#5
Open
mtf90 wants to merge 1 commit intocodesqueak:masterfrom
Open
Use serializer from createContextual as base deserializer#5mtf90 wants to merge 1 commit intocodesqueak:masterfrom
createContextual as base deserializer#5mtf90 wants to merge 1 commit intocodesqueak:masterfrom
Conversation
createContextual as base deserializercreateContextual as base deserializer
shatterblast
approved these changes
Mar 6, 2020
|
why isn't this included in 2.1? |
f1c5d89 to
44f4340
Compare
Author
|
We recently ran into the same issue again when upgrading our Wildfly stack (and switching to jackson-json-crypto 2.2.0). I noticed that the PR was no longer mergable so I rebased it against the latest master. Are there any objections to merging this? It would certainly make life easier not having to ship a custom hot-fix version for this 😆. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jackson seems to provide different
DeserializationContextinstances to thedeserializeandcreateContextualmethods. We have observed that thegetContextualType()method on the context passed to thedeserializemethod would often returnnull, whereas the context passed tocreateContextualwould correctly allow one to extract the contextual type.The current implementation does not allow one to use the correct context in their own serializer, since the context passed to the delegating
createContextualmethod is always the one of theserializemethod. This pull-requests creates the effective serializer in thecreateContextualmethod instead of thedeserializemethod.Wether or not the two different contexts may be an actual bug in Jackson, I believe this change still handles the delegation process more cleanly by delegating to the
createContextualcall in the actualcreateContextualmethod.