Skip to content

Conversation

@samsatoshis
Copy link
Collaborator

adding cache to the open-meteo api data, the cached data covers the period from 1990-01-01, to 2024-12-08. If a request falls outside this date range, the system will fetch the data directly from open-meteo, otherwise, it will return the cached data.

@wherop
Copy link
Collaborator

wherop commented Dec 11, 2024

Looks good. Sensible changes, clear logic.
On the long term, it could make sense to do some of the processing/aggregation before caching and store just one data point per day. But this works well for now.

@wherop wherop merged commit 10618a1 into main Dec 11, 2024
1 check passed
@wherop wherop deleted the weather-module-refactor branch December 11, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants