Fix .comment-meta width issue#1598
Conversation
|
Is the test failure one of the flaky tests addressed in #1569? I don't see how this tiny CSS change would cause that to fail on one single ruby version otherwise |
Yeah, judging by the error message, it's the flaky system tests, yeah, I'll rerun the pipeline shortly |
|
Oh, I just realized I've noticed the issue too and fixed it in my PR with fixes related to the button: 2e7578c. Not sure how to proceed, though, our fixes might be complementary |
|
Maybe it's worth reconsidering the problematic rule instead of doing this fix? I don't think the entire subtree needs a max-width, so maybe - * {
+ > * {
max-width: 100%;
}Or something like that? I have not tested this rule, nor have I checked if that backfires, but I'm pretty sure the problem it was trying to fix was immediate descendants of the post, and not the entire subtree. Might've been an either inline mathjax or mathjax block fix as well, but that could be done separately |
|
Superseded by #1584 |
#1558 introduced a
max-widthcondition that, for reasons I don't understand and likely never will, caused comment boxes to start underflowing:Fix verified in:
/thread/{id}/posts/{id}This PR fixes this bug. AFAIK, it has not been reported anywhere (yet).