Open
Conversation
Author
|
@nurmerey GHC20 |
nurmerey
requested changes
Oct 28, 2020
Contributor
nurmerey
left a comment
nurmerey
left a comment
There was a problem hiding this comment.
Hi @innovation16 thank you for your contribution, added a few comments here, once they are addressed this will be good to be merged. Let me know if you have any questions.
|
|
||
| Please find an installation guide for your environment in our [Wiki](https://github.com/shescoding/projects-platform-frontend/wiki). | ||
|
|
||
| ## 🏃 Running the project |
Contributor
There was a problem hiding this comment.
Heya, our apologies, this file has been rewritten here since after the GHC https://github.com/shescoding/projects-platform-frontend/wiki/Project-Installation-Guide, plz remove changes to Readme.md
| "dotenv": "8.2.0", | ||
| "github-oauth": "0.2.2", | ||
| "js-cookie": "2.2.1", | ||
| "nodemon": "^2.0.4", |
Contributor
There was a problem hiding this comment.
You are right, we do need nodemon, thank you for adding this. Can you please remove ^ before the version number to ensure it does not auto update?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
To run local server, we need nodemon, which was missing from the dependencies.
Fix:
Added nodemon as a dev dependency.
Also added documentation describing how to run the local server and to start the project.