adding table and api ~ Positions#154
Open
ShiviBhatt wants to merge 2 commits intocoding-allies:masterfrom
Open
adding table and api ~ Positions#154ShiviBhatt wants to merge 2 commits intocoding-allies:masterfrom
ShiviBhatt wants to merge 2 commits intocoding-allies:masterfrom
Conversation
nurmerey
requested changes
Oct 21, 2020
Contributor
nurmerey
left a comment
nurmerey
left a comment
There was a problem hiding this comment.
Looking good Shivi! Just a few requests. Plz let me know if something that I asked is not clear!
| } | ||
|
|
||
| router.get("/getPositions", (req, res) => { | ||
| const positions = getPositions(res); |
Contributor
There was a problem hiding this comment.
Let's check if the user is authenticated first here. You can see an example of that from other APIs in this file.
| }); | ||
| }); | ||
|
|
||
| //Positions method |
Contributor
There was a problem hiding this comment.
nit: space after // and before Positions
| let SQL = 'SELECT * FROM Positions;'; | ||
| return client.query(SQL) | ||
| .then(result => { | ||
| console.log(result); |
Contributor
There was a problem hiding this comment.
This should probably return rather than console.log?
| async function getAccessToken(code, client_id, client_secret) { | ||
| const result = await axios( | ||
| { | ||
| const result = await axios({ |
Contributor
There was a problem hiding this comment.
Please remove all automatic formatting like this added to this file that does not directly part of this PR.
Contributor
|
@ShiviBhatt let me know if you have any questions! It looks like you are very close to finishing the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work and Validation of Positions table and API work