feat(http): radix tree matcher for route matching#12
Open
burakkoken wants to merge 2 commits intomainfrom
Open
feat(http): radix tree matcher for route matching#12burakkoken wants to merge 2 commits intomainfrom
burakkoken wants to merge 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a radix-tree-based EndpointMatcher implementation to support fast route matching (static, params, glob-like patterns, *, and **) and enables ServerRequest.PathValue(...) to return captured path parameters.
Changes:
- Introduces
radixTreeMatcherwith route registration + matching, including path normalization and param capture. - Adds per-request storage for captured path parameters and wires
ServerRequest.PathValue(...)to it. - Adds extensive unit tests + a benchmark for matcher behavior and priority rules.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| http/request.go | Adds internal storage for captured path params; implements PathValue; changes Method() return type. |
| http/context.go | Adds endpoint field + accessor/mutator and introduces NewContext. |
| http/endpoint.go | Reorders fields in Endpoint (no functional change). |
| http/matcher.go | New radix-tree matcher implementation and supporting helpers. |
| http/matcher_test.go | New comprehensive matcher tests and benchmark. |
Comments suppressed due to low confidence (1)
http/context.go:116
Context.resetclears request/response state but does not reset the newly addedendpointfield or any capturedpathValues. IfContextinstances are reused (asresetsuggests), this can leak routing state between requests. Consider settingc.endpoint = niland resettingc.req.pathValueshere as well.
func (c *Context) reset(w http.ResponseWriter, r *http.Request) {
c.err = nil
clear(c.values)
c.req.nativeReq = r
c.req.cookiesCache = nil
c.req.queryCache = nil
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.