feat(Workflows): Add missing unknown classes for future-compatibility#2627
Open
haakonvt wants to merge 3 commits into
Open
feat(Workflows): Add missing unknown classes for future-compatibility#2627haakonvt wants to merge 3 commits into
haakonvt wants to merge 3 commits into
Conversation
…#2623) Co-authored-by: Sachin Bhagwat <sachin.bhagwat@cognite.com> Co-authored-by: Cursor <cursoragent@cursor.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements forward compatibility for workflow tasks by adding fallback classes for unknown task types and refactoring loading logic to use match statements. It also standardizes internal loading methods to _load and updates Postgres Gateway integration tests. Feedback was provided to correct a terminology error in a warning message within the UnknownWorkflowTaskParameters class, ensuring it correctly refers to 'parameters' instead of 'output'.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## pysdk-release-v7 #2627 +/- ##
====================================================
+ Coverage 91.02% 91.04% +0.02%
====================================================
Files 192 192
Lines 26227 26266 +39
====================================================
+ Hits 23872 23914 +42
+ Misses 2355 2352 -3
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from
master(i.e. v8)