Ignore unsupported and Nexus events#355
Open
jeffschoner wants to merge 4 commits intocoinbase:masterfrom
Open
Conversation
Add support for ignoring events that the worker doesn't handle, including Nexus operation events and WORKFLOW_EXECUTION_OPTIONS_UPDATED. Events with the worker_may_ignore bit set are also gracefully skipped with a warning log. Committed-By-Agent: claude
Allow -1s lower bound for clock drift between Docker dev server and host. Committed-By-Agent: claude
jazev-stripe
approved these changes
May 4, 2026
Contributor
jazev-stripe
left a comment
There was a problem hiding this comment.
The Ruby changes all match what we are running at Stripe in our fork (and have successfully deployed to our services).
The Protobuf generation changes should be good; in particular the add_serialized_file API used by more modern protoc is compatible going back to google-protobuf v3.18: source
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WORKFLOW_EXECUTION_OPTIONS_UPDATED). These events are logged and skipped rather than crashing the worker.worker_may_ignorebit on history events, allowing the server to introduce new event types without breaking older workers.Details
When a workflow history contains event types the SDK doesn't handle (e.g. Nexus operations or
WORKFLOW_EXECUTION_OPTIONS_UPDATED), the state manager now:worker_may_ignoreflag from the server — if set, logs and skips; otherwise raisesUnsupportedEvent.The proto upgrade to v1.62.9 ensures these event types are properly deserialized (previously they mapped to
EVENT_TYPE_UNSPECIFIEDsince the enum didn't include them).Test plan
bundle exec rspec— 662 examples, 0 failuresexamples/spec/replay/signal_with_start_ignored_event_spec.rb— replay test passes with ignored eve