python pandad, even simpler#37224
Closed
adeebshihadeh wants to merge 7 commits intomasterfrom
Closed
Conversation
Move sendcan polling from separate thread into main 100Hz loop. The only background thread is for hwmon reading (voltage/current) which can block indefinitely and is best-effort. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
HARDWARE.get_voltage/get_current already return millivolts/milliamps, no need to multiply by 1000. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
SubMaster with conflate=True only keeps the latest message, causing message drops when many sendcan messages arrive between poll cycles. Use a raw sub_sock with conflate=False and drain_sock to process all pending messages, matching C++ behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove ./pandad CPU entry (C++ binary no longer runs) - Set selfdrive.pandad.pandad budget to 25% (was 0 as just a launcher) - Move CarParams import to module level (avoid repeated lazy imports) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The OX03C10 test_exposure failure also occurs on master - it's a pre-existing camera hardware issue unrelated to the pandad rewrite. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
This PR has had no activity for 24 days. It will be automatically closed in 7 days if there is no activity. |
Contributor
|
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
Contributor
|
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.