Conversation
board/drivers/gpio.h
Outdated
| #define PULL_DOWN 2 | ||
|
|
||
| #define OUTPUT_TYPE_PUSH_PULL 0U | ||
| #define OUTPUT_TYPE_OPEN_DRAIN 1U |
Contributor
There was a problem hiding this comment.
I'd just make these an enum
Contributor
That's where I got stuck. i think the best way would be to use But first this test needs to be fixed. |
maxime-desroches
force-pushed
the
misra_2_5_reals
branch
from
80e3033 to
b1ffee7
Compare
liruifeng1120
pushed a commit
to liruifeng1120/panda
that referenced
this pull request
Dec 24, 2025
The [Nissan A][1] and B harnesses do not have 12VIN, only IGN, so presumably they need a comma power too. It [looks like][2] they are already shipped with them. [1] https://github.com/commaai/hardware/blob/master/harness/v3/Nissan_A_Harness.pdf [2] https://discord.com/channels/469524606043160576/580827831307599872/1265508977626845279
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only removed unused ones. Will have to plan how to deal with false positives from cppcheck