Prerender Issue — IOEXT-1811 (maxVersion error) #711
Prerender Issue — IOEXT-1811 (maxVersion error) #711
Conversation
…/microsite-commerce-storefront into nasm-config-assets
Reverts changes lost in merge commit d5b5790. Restores: - ## How it works as proper heading - Tasks/Task components for installation steps - Options/Option components for troubleshooting - Full original content (757 lines) Co-authored-by: Cursor <cursoragent@cursor.com>
add empty line after title
There was a problem hiding this comment.
Use AI to clean up the PR before pushing. If you download (update) the comdox toolkit, Dima added an /exl-validation and a /refactor command. I'm not sure how /exl-validation will work on the storefront content, but give it a try.
The refactor command was originally created for code, but I found that it works for reviewing the content and suggesting updates that improve content quality. Give it a try.
Co-authored-by: Margaret Eker <meker@adobe.com>
| </TableWrapper> | ||
|
|
||
| <Aside type="note" title="Commerce configuration"> | ||
| The prerender app reads Commerce configuration (endpoints, headers, and store context) from your storefront's `config.json` file, not from environment variables. Verify that your storefront has a properly configured `config.json` file with the required Commerce endpoints and headers as described in the <Link href="/setup/configuration/commerce-configuration/" text="Storefront configuration" /> documentation. For Adobe Commerce Optimizer, configure the appropriate headers (`AC-View-ID`, `AC-Source-Locale`, `AC-Price-Book-ID`) in your storefront's `config.json` file. |
There was a problem hiding this comment.
| The prerender app reads Commerce configuration (endpoints, headers, and store context) from your storefront's `config.json` file, not from environment variables. Verify that your storefront has a properly configured `config.json` file with the required Commerce endpoints and headers as described in the <Link href="/setup/configuration/commerce-configuration/" text="Storefront configuration" /> documentation. For Adobe Commerce Optimizer, configure the appropriate headers (`AC-View-ID`, `AC-Source-Locale`, `AC-Price-Book-ID`) in your storefront's `config.json` file. | |
| The prerender app reads Commerce configuration (endpoints, headers, and store context) from your site's configuration, not from environment variables. Verify that your storefront has a properly configured site configuration with the required Commerce endpoints and headers as described in the <Link href="/setup/configuration/commerce-configuration/" text="Storefront configuration" /> documentation. For Adobe Commerce Optimizer, configure the appropriate headers (`AC-View-ID`, `AC-Source-Locale`) in your site configuration. |
AC-Price-Book-ID should be automatic based on user auth state after next "release", assuming configuration set up correctly (adobe-commerce-optimizer: true).
Also let's stop using the config.json term. It should be "site configuration".
| generateSidebar(), | ||
| { | ||
| exclude: ['/sdk/**', '/videos/**', '/dropins-b2b/**', '/merchants/storefront-builder/**'], | ||
| exclude: ['/sdk/**', '/videos/**', '/dropins-b2b/**', '/merchants/storefront-builder/**', '/get-started/howitallworks/**'], |
There was a problem hiding this comment.
@sirugh — It's an artifact to fix the build when merging conflicts arise with the preview branch that holds lots of other PRs.
Sorry for the churn and extra changes that got into this PR. Moving forward:
- I'll direct tech reviewers to the relevant files to review.
- Keep the PRs slim (no refactoring) so the review is as simple as possible.
- Tech reviewers should approve first, so they can be about their way.
Thanks for the feedback.
|
I appreciate that we want to continually improve our docs, but I think sandbagging a big refactor when the issue is smaller makes it difficult to review or get changes out quickly. Like, the PR description says:
So I would assume that the change might be a few lines, simple to review. But now that change is buried in a mountain of refactor. Are we meant to review the refactor or just the specific change that is the reason the PR was created? |
|
|
||
| **Commerce credentials** (Adobe Commerce Optimizer): Configure your Commerce backend connection according to your deployment type. For details on configuring Optimizer headers and endpoints, see the <Link href="/setup/configuration/commerce-configuration/" text="Storefront configuration" /> documentation for details. | ||
|
|
||
| **Note**: The prerender app reads Commerce configuration (endpoints and headers) from your storefront's `config.json` file, not from environment variables. Before deployment, verify that `config.json` is correctly configured. |
There was a problem hiding this comment.
Same note re config.json vs "site configuration".
| **Note**: The prerender app reads Commerce configuration (endpoints and headers) from your storefront's `config.json` file, not from environment variables. Before deployment, verify that `config.json` is correctly configured. | ||
|
|
||
| <Aside type="caution" title="Required: maxVersion in productDependencies"> | ||
| If your `app.config.yaml` includes a `productDependencies` array, **each entry must include `maxVersion`**. Otherwise, the `aio app build` command fails with a validation error. |
There was a problem hiding this comment.
Does the prerender repo come with a "default" or "reference" app.config.yaml? If so, should we just fix it there instead of making a docs change?
Or, is this a scenario that happens in specific situations, like maybe productDependencies is added if you have some specific version of aio?
There was a problem hiding this comment.
There is a default template; all that's needed after testing is to uncomment the lines and deploy. I'm not familiar with maxVersion. We have never used it.
| </TableWrapper> | ||
|
|
||
| <Aside type="note" title="Commerce configuration"> | ||
| The prerender app reads Commerce configuration (endpoints, headers, and store context) from your storefront's `config.json` file, not from environment variables. Verify that your storefront has a properly configured `config.json` file with the required Commerce endpoints and headers as described in the <Link href="/setup/configuration/commerce-configuration/" text="Storefront configuration" /> documentation. For Adobe Commerce Optimizer, configure the appropriate headers (`AC-View-ID`, `AC-Source-Locale`, `AC-Price-Book-ID`) in your storefront's `config.json` file. |
| **Note**: The prerender app reads Commerce configuration (endpoints and headers) from your storefront's `config.json` file, not from environment variables. Before deployment, verify that `config.json` is correctly configured. | ||
|
|
||
| <Aside type="caution" title="Required: maxVersion in productDependencies"> | ||
| If your `app.config.yaml` includes a `productDependencies` array, **each entry must include `maxVersion`**. Otherwise, the `aio app build` command fails with a validation error. |
There was a problem hiding this comment.
There is a default template; all that's needed after testing is to uncomment the lines and deploy. I'm not familiar with maxVersion. We have never used it.
| **Correct format:** | ||
| ```yaml | ||
| productDependencies: | ||
| - code: <PRODUCT_CODE> | ||
| minVersion: <MIN_VERSION> | ||
| maxVersion: <MAX_VERSION> # Required | ||
| ``` | ||
|
|
||
| **Incorrect format (will cause build failure):** | ||
| ```yaml | ||
| productDependencies: | ||
| - code: <PRODUCT_CODE> | ||
| minVersion: <MIN_VERSION> | ||
| # Missing maxVersion - build will fail | ||
| ``` |
There was a problem hiding this comment.
I think it's not needed for this project
| ### Enable automated synchronization | ||
|
|
||
| After deployment, perform the following steps: | ||
| - Use the <Link href="https://prerender.aem-storefront.com" text="Management UI" /> to start the change detector |
There was a problem hiding this comment.
The context will only appear here if we complete all the installation steps in the local environment.
| - Update your `app.config.yaml` file and redeploy with `npm run deploy` | ||
| <Option> | ||
|
|
||
| ### Build error: Missing maxVersion in productDependencies |
| productDependencies: | ||
| - code: <PRODUCT_CODE> | ||
| minVersion: <MIN_VERSION> | ||
| maxVersion: <MAX_VERSION> # Required field | ||
| ``` |
There was a problem hiding this comment.
probably we should remove it
|
Closed because they closed the ticket and @baranovskyalexandr told me it was not associated with prerender as I initially thought from early slack messages regarding the problem. |
Purpose of this pull request
This pull request (PR) updates the aem-prerender installation to document the fix to the error that NASM recently encountered:
The error occurs when running
aio app buildin a CI/CD pipeline. Theapp.config.yamlfile has aproductDependenciesarray, and at least one entry is missing the required maxVersion property.The error message indicates:
/productDependencies/0(first entry in the array)maxVersionmaxVersionis now required for eachproductDependenciesentryAssociated JIRA ticket
https://jira.corp.adobe.com/browse/IOEXT-1811
Staging preview
Affected pages
https://experienceleague.adobe.com/developer/commerce/storefront/setup/configuration/aem-prerender/