-
-
Notifications
You must be signed in to change notification settings - Fork 21
Add more TypedDict definitions
#393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
e5420a6 to
8ae3b07
Compare
mr-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I think there are some Seven Bridges workflows that decorate input and output Files and Directories with additional fields and reference those fields from CWL Parameter Expressions.
See common-workflow-language/common-workflow-language#710 for some references to this.
So I don't think we can discard or throw an error on references to additional fields. An engine could optimize for the standard fields and use a slower path for extension fields, if that helps.
|
Is that allowed by the standard? Shouldn't it be a ns:MyFile class object that extends File? |
8ae3b07 to
1ab8feb
Compare
|
@mr-c btw I think I fixed it. I also foud a slightly better way to check keys through |
Extra namespaced fields are allowed |
This commit checks that the new `TypedDict` type aliases specified in cwl-utils with PR common-workflow-language/cwl-utils#393 do not break anything in the cwltool type system.
11526da to
7c8a166
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
==========================================
+ Coverage 34.66% 34.69% +0.02%
==========================================
Files 30 30
Lines 35412 35437 +25
Branches 9538 9541 +3
==========================================
+ Hits 12275 12294 +19
- Misses 20257 20261 +4
- Partials 2880 2882 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fa58afd to
985b93e
Compare
This commit adds more `TypedDict` definitions for `File`, `Dirent`, and `Directory` objects. In addition, it adds the `exitCode` entry to the `CWLRuntimeParameterContext`, which was missing.
985b93e to
af8b854
Compare
This commit adds more
TypedDictdefinitions forFile,Dirent, andDirectoryobjects. In addition, it adds theexitCodeentry to theCWLRuntimeParameterContext, which was missing.