micropython: hardcode _PACKAGE_INDEX value for robust patching#126
Open
AJMansfield wants to merge 1 commit intocompiler-explorer:mainfrom
Open
micropython: hardcode _PACKAGE_INDEX value for robust patching#126AJMansfield wants to merge 1 commit intocompiler-explorer:mainfrom
AJMansfield wants to merge 1 commit intocompiler-explorer:mainfrom
Conversation
Signed-off-by: Anson Mansfield <amansfield@mantaro.com>
AJMansfield
force-pushed
the
mpy-hermetic
branch
from
30b340d to
3e88edf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MicroPython has a concept of "parser constants", i.e. values that aren't real variables but just substitutions made while parsing the python source.
_PACKAGE_INDEXis, in some versions that this mip patch needs to apply to, a parser constant that's only defined after the import statement it's patching against, leading to an error when attempting to use the patch package manager.