Skip to content

Reapply update to cppinterop 1.8.0#448

Open
anutosh491 wants to merge 1 commit intomainfrom
revert-445-revert_cppinterop_1.8_temporary
Open

Reapply update to cppinterop 1.8.0#448
anutosh491 wants to merge 1 commit intomainfrom
revert-445-revert_cppinterop_1.8_temporary

Conversation

@anutosh491
Copy link
Collaborator

Reverts #445

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.25%. Comparing base (d5dfb61) to head (08a01c8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
- Coverage   81.94%   81.25%   -0.70%     
==========================================
  Files          21       21              
  Lines         853      864      +11     
  Branches       87       78       -9     
==========================================
+ Hits          699      702       +3     
- Misses        154      162       +8     
Files with missing lines Coverage Δ
src/xinspect.cpp 94.11% <ø> (ø)

... and 3 files with indirect coverage changes

Files with missing lines Coverage Δ
src/xinspect.cpp 94.11% <ø> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants