Transparency log: skip VersionDeleted event if package was deleted
#1623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94noni
reviewed
Dec 3, 2025
Seldaek
reviewed
Dec 10, 2025
src/Model/PackageManager.php
Outdated
| $versionRepo = $this->doctrine->getRepository(Version::class); | ||
| foreach ($package->getVersions() as $version) { | ||
| $versionRepo->remove($version); | ||
| $versionRepo->remove($version, true); |
Member
There was a problem hiding this comment.
Shouldn't this be false? And I'd probably set it to false in CleanSpamPackagesCommand.php:69 as well as this is useless noise in the DB.
Contributor
Author
There was a problem hiding this comment.
Whoops. This should be false, yep. Seeing how that is the entire point of the PR 😅
Also updated that in CleanSpamPackagesCommand now.
stevenrombauts
force-pushed
the
only-track-package-delete
branch
from
8769578 to
6c32230
Compare
stevenrombauts
force-pushed
the
only-track-package-delete
branch
from
6c32230 to
8fc7a2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stops creating
VersionDeletedaudit records if the versions are being removed because the we're deleting the package.It just moves the creation of the record from
VersionListener::preRemovetoVersionRepository::remove()