-
Notifications
You must be signed in to change notification settings - Fork 6
Update to Unicode16.0.0 + misc #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b05b5f5 to
fcc9322
Compare
|
@wismill Welcome back! Thank you for the PR. I'll start reviewing the PR soon. From: #138 (comment)
Do you have a suspicion of where these bits might be? I can go through those parts more throughly |
Commit by commit, unless you feel adventurous 😉
It's difficult to describe unfortunately. I did try to put some guards, but some conversions may be silently lossy, e.g. with |
65747e1 to
b53afff
Compare
|
Minor refactor + doc. I transformed assertions into mandatory tests in the generator, so we do not skip them if using |
This enables to support a wide range of `base` versions by having the migration bits in a single place.
Enable to encode any finite integral type: - generalize generateShamochuBitmaps; - generalize genEnumBitmapShamochu.
This will enable to process Unicode 16.0.
b53afff to
a4e49fe
Compare
|
Rebased. |
|
@wismill I'll review the PR over the weekend. |
|
Since Unicode 17.0 has been published, let’s merge this to enable fixing #143. I will publish the new versions shortly after. |
Mega update:
Fixes #137
Fixes #138
I will publish a new version once this get merged.
PS: Sorry for the big MR, it’s easier for me this time.
@adithyaov