Skip to content

Conversation

@wismill
Copy link
Collaborator

@wismill wismill commented Aug 26, 2025

Mega update:

  • Update the generator to be able to process Unicode 16.0
  • Update CI with latest GHC
  • Update to Unicode 16.0.0
  • Fix tests
  • Bump packages versions

Fixes #137
Fixes #138

I will publish a new version once this get merged.

PS: Sorry for the big MR, it’s easier for me this time.

@adithyaov

@adithyaov
Copy link
Member

@wismill Welcome back! Thank you for the PR. I'll start reviewing the PR soon.
Do you recommend I review it commit by commit or look at the entire diff at once?

From: #138 (comment)

I am still a bit uneasy there could be still some hard-coded bits in ucd2haskell that assume all values can be encoded as Word8

Do you have a suspicion of where these bits might be? I can go through those parts more throughly

@wismill
Copy link
Collaborator Author

wismill commented Aug 26, 2025

Do you recommend I review it commit by commit or look at the entire diff at once?

Commit by commit, unless you feel adventurous 😉

I am still a bit uneasy there could be still some hard-coded bits in ucd2haskell that assume all values can be encoded as Word8

Do you have a suspicion of where these bits might be? I can go through those parts more throughly

It's difficult to describe unfortunately. I did try to put some guards, but some conversions may be silently lossy, e.g. with fromIntegral.

@wismill wismill force-pushed the unicode/16.0.0 branch 2 times, most recently from 65747e1 to b53afff Compare August 27, 2025 10:13
@wismill
Copy link
Collaborator Author

wismill commented Aug 27, 2025

Minor refactor + doc. I transformed assertions into mandatory tests in the generator, so we do not skip them if using -O2.

@wismill wismill mentioned this pull request Aug 28, 2025
@wismill
Copy link
Collaborator Author

wismill commented Aug 28, 2025

Rebased.

@adithyaov
Copy link
Member

@wismill I'll review the PR over the weekend.
We're in the process of releasing streamly. A lot of my time is going to misc release todos.

@wismill
Copy link
Collaborator Author

wismill commented Sep 13, 2025

Since Unicode 17.0 has been published, let’s merge this to enable fixing #143.

I will publish the new versions shortly after.

@wismill wismill merged commit f3a8c12 into composewell:master Sep 13, 2025
18 checks passed
@wismill wismill deleted the unicode/16.0.0 branch September 13, 2025 18:06
@wismill
Copy link
Collaborator Author

wismill commented Sep 13, 2025

Candidates:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to update Unicode version to 16.0.0 unicode-data-0.6.0 testsuite: update to Unicode 16

2 participants