Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull request overview
Adds support for environment-gated Schema Registry rule execution by introducing an enableAt attribute on RuleSet, propagating it through RuleContext, and using it to skip rule execution in both sync and async serdes.
Changes:
- Add
enable_at/enableAttoRuleSet(serialization, deserialization, hashing). - Extend
RuleContextwithenabled_envand pass it from schemas’ rule sets during rule execution. - Gate rule execution in
_is_disabled()based onenableAtfor both sync and async serdes.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/confluent_kafka/schema_registry/common/serde.py | Adds enabled_env to RuleContext to carry rule-set environment gating data. |
| src/confluent_kafka/schema_registry/common/schema_registry_client.py | Adds enable_at to RuleSet and includes it in dict (de)serialization and hashing. |
| src/confluent_kafka/schema_registry/_sync/serde.py | Propagates enable_at into RuleContext and skips rules based on environment gating. |
| src/confluent_kafka/schema_registry/_async/serde.py | Async equivalent of sync gating and context propagation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
22831c6 to
937caea
Compare
937caea to
de21d5c
Compare
|


What
Add enableAt to RuleSet. Also update CHANGELOG
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups