Remove callback wrapping for oauth_cb in AIO clients#2219
Open
Ojasva Jain (ojasvajain) wants to merge 4 commits intomasterfrom
Open
Remove callback wrapping for oauth_cb in AIO clients#2219Ojasva Jain (ojasvajain) wants to merge 4 commits intomasterfrom
Ojasva Jain (ojasvajain) wants to merge 4 commits intomasterfrom
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
airlock-confluentinc
bot
requested review from
a team and
Matthew Seal (MSeal)
as code owners
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2171
Fixed AIOConsumer/AIOProducer initialization failures by removing oauth_cb wrapping in
_common.wrap_common_callbacks(). The OAuth callback is invoked by librdkafka'sbackground thread and must be called directly, not scheduled on the event loop.
Created dedicated test file
test_oauth_cb.py, moved oauth_cb related test cases fromtest_misc.pyfor better organization.