fix(CI): use single quotes for pushing test result artifacts on Windows agents#3350
Merged
Dave Shoup (shouples) merged 5 commits intomainfrom Mar 30, 2026
Merged
Conversation
…tifacts on Windows agents
There was a problem hiding this comment.
Pull request overview
This PR updates Semaphore CI Windows job scripts to use single-quoted strings when publishing test results, improving command-line argument handling on Windows agents.
Changes:
- Switch
test-results publish --namearguments from double quotes to single quotes in Windows PowerShell epilogues. - Apply the same quoting adjustment in both the main pipeline and the Playwright E2E pipeline.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.semaphore/semaphore.yml |
Uses single quotes for --name when publishing E2E + Webview test results on Windows. |
.semaphore/playwright-e2e.yml |
Uses single quotes for --name when publishing E2E test results on Windows. |
|
| if (Test-Path $TestResultE2EFileName) { | ||
| $fileInfo = Get-Item $TestResultE2EFileName | ||
| Write-Output "Publishing E2E test results from $($fileInfo.FullName) ($($fileInfo.Length) bytes)" | ||
| $TestResultName = 'VS Code ({0}) Extension Tests: E2E (win32 x64)' -f $Env:VSCODE_VERSION |
Contributor
Author
There was a problem hiding this comment.
Subtle change to also show the VSCODE_VERSION param value in the job name instead of hard-coding stable
Comment on lines
+401
to
+404
| options: | ||
| - "all" | ||
| - "linux" | ||
| - "windows" |
Contributor
Author
There was a problem hiding this comment.
Small unrelated change that made testing this in promotions easier since it now appears as a dropdown (like the standalone task):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure when the behavior started, but we recently started seeing failures from the Windows agents in CI when they attempted to push test results as Semaphore artifacts (via
test-results publish ...):This turned out to be a problem with how the filenames were being handled, which is now working as expected:
