feat(node-type-registry): add DataLimitCounter, DataFeatureFlag, AuthzAppMembership#1060
Merged
pyramation merged 2 commits intomainfrom May 6, 2026
Merged
feat(node-type-registry): add DataLimitCounter, DataFeatureFlag, AuthzAppMembership#1060pyramation merged 2 commits intomainfrom
pyramation merged 2 commits intomainfrom
Conversation
…zAppMembership - DataLimitCounter: attaches limit-tracking triggers (increment on INSERT, decrement on DELETE) - DataFeatureFlag: gates tables behind cap-based feature flags (max=0/1) - AuthzAppMembership: app-level membership check (hardcoded membership_type=1), replaces AuthzMembership for clarity
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…pMembership - Delete authz-membership-check.ts (the old AuthzMembership type) - Remove export from authz/index.ts - Regenerate blueprint-types with AuthzAppMembership in the union
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstreams 3 node type definitions currently defined locally in
constructive-db, and removes the deprecatedAuthzMembership:DataLimitCounter— Declarative limit-tracking triggers (increment on INSERT, decrement on DELETE). Requires a provisionedlimits_module.DataFeatureFlag— Gates tables behind cap-based feature flags (max=0disabled,max=1enabled). Backed bylimit_caps/limit_caps_defaultstables.AuthzAppMembership— App-level membership check hardcoded tomembership_type=1. Replaces the oldAuthzMembershipwhich has been removed.Breaking change:
AuthzMembershipis removed from the package. All consumers should useAuthzAppMembershipinstead. Theconstructive-dbRLS parser and generators already only acceptAuthzAppMembership.Once published as a new npm version, the local definitions in
constructive-db/packages/node-type-registry/src/can be removed — the dedup logic ingenerate.tsautomatically drops local types that exist upstream.Review & Testing Checklist for Human
AuthzMembershipfrom this packageparameter_schemafor each new type matches whatconstructive-dbgenerators expectnode-type-registryinconstructive-dband remove the 3 local.tsfilesNotes
Net change: 58 types (was 57). Added 3 new types, removed 1 old type (
AuthzMembership). Build passes, blueprint types regenerated.Link to Devin session: https://app.devin.ai/sessions/b4ff120294f446d8a0407ac21e05f7bb
Requested by: @pyramation