Skip to content

Conversation

@pczarn
Copy link
Contributor

@pczarn pczarn commented Jul 16, 2024

No description provided.

@pczarn
Copy link
Contributor Author

pczarn commented Jan 26, 2025

@Jujumba Could you review this? Any ideas on this?

@pczarn
Copy link
Contributor Author

pczarn commented Jan 26, 2025

We might find some more Clippy lints fit for our projects. They do run in the CI.

Thanks in advance.

Copy link
Contributor

@Jujumba Jujumba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I personally use variable shadowing from time to time, so not quite sure how this will affect future contributions. Perhaps we should write CONTRIBUTIONS.md guide, or whatever?

@Jujumba
Copy link
Contributor

Jujumba commented Jan 28, 2025

I propose we also apply the following lints:

Checks for matches with a single arm where an if let will usually suffice.

Suggests the use of const in functions and methods where possible.

Suggests the use of const in functions and methods where possible.

@pczarn

@pczarn
Copy link
Contributor Author

pczarn commented Jan 28, 2025

Also

multiple_bound_locations 📋
suspicious warn
What it does

Check if a generic is defined both in the bound predicate and in the where clause.

multiple_inherent_impl

@pczarn
Copy link
Contributor Author

pczarn commented Jan 29, 2025

The const fn lint should not be used on stable. We're working on stable.

@pczarn
Copy link
Contributor Author

pczarn commented Jun 8, 2025

@Jujumba All good with the recent rebase?

@Jujumba
Copy link
Contributor

Jujumba commented Jun 8, 2025

@Jujumba All good with the recent rebase?

I can clean build this branch, if that's what you are asking

image

@pczarn pczarn merged commit 9893e6a into master Jun 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants