-
Notifications
You must be signed in to change notification settings - Fork 65
Enable some clippy lints #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Jujumba Could you review this? Any ideas on this? |
|
We might find some more Clippy lints fit for our projects. They do run in the CI. Thanks in advance. |
Jujumba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I personally use variable shadowing from time to time, so not quite sure how this will affect future contributions. Perhaps we should write CONTRIBUTIONS.md guide, or whatever?
|
I propose we also apply the following lints:
|
|
The const fn lint should not be used on stable. We're working on stable. |
|
@Jujumba All good with the recent rebase? |
I can clean build this branch, if that's what you are asking |

No description provided.