Remove buf update from make protos #91
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The protos target gets run during CI to validate there are not ungenerated proto changes. The updates can change at any point if buf dependencies are updated at this point. While it is unlikely they will change often, they should change intentially, just as go dependencies would happen. Signed-off-by: Derek McGowan <derek@mcg.dev>
There was a problem hiding this comment.
Pull request overview
Removes automatic Buf dependency updates from the make protos workflow so CI proto generation checks remain deterministic and only change when dependencies are intentionally updated/committed.
Changes:
- Removed
buf dep updatefrom theprotosMakefile target while keepingbuf generateand descriptor build steps intact.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The protos target gets run during CI to validate there are not ungenerated proto changes. The updates can change at any point if buf dependencies are updated at this point. While it is unlikely they will change often, they should change intentially, just as go dependencies would happen.