adaptation: close plugin if initial sync fails.#279
Merged
fuweid merged 1 commit intocontainerd:mainfrom Mar 14, 2026
Merged
Conversation
klihub
force-pushed
the
fixes/close-on-sync-failure
branch
from
b9a0b02 to
665d57a
Compare
klihub
force-pushed
the
fixes/close-on-sync-failure
branch
from
665d57a to
db4a7a3
Compare
Member
Author
|
@mikebrow @chrishenzie @fuweid Guys, could we get this fix in ? It is literally almost a oneliner. |
fuweid
approved these changes
Mar 13, 2026
Member
|
@klihub it looks like CI is not happy |
klihub
force-pushed
the
fixes/close-on-sync-failure
branch
3 times, most recently
from
a4aa6db to
4324bd3
Compare
Member
Author
fuweid
previously approved these changes
Mar 13, 2026
Member
I can't merge it. = =! |
Don't leave a plugin connected but effectively unregistered if initial plugin synchronization fails. Log the fact as an error and close the plugin. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
klihub
force-pushed
the
fixes/close-on-sync-failure
branch
from
4324bd3 to
370f3d5
Compare
fuweid
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't leave a plugin connected but effectively unregistered if initial plugin synchronization fails. Log the fact as an error instead of info and close the plugin.