Skip to content

bump selinux to v1.15.0, use SetProcessKind#28693

Open
kolyshkin wants to merge 1 commit into
containers:mainfrom
kolyshkin:change-label
Open

bump selinux to v1.15.0, use SetProcessKind#28693
kolyshkin wants to merge 1 commit into
containers:mainfrom
kolyshkin:change-label

Conversation

@kolyshkin
Copy link
Copy Markdown
Contributor

@kolyshkin kolyshkin commented May 13, 2026

Use oc/selinux v1.15.0 and its new SetProcessKind to streamline changing the label type.

Notes:

  • I was not able to find any external users of pkg/selinux but kept it
    for now (and marked as deprecated and with go:fix inline) so
    any users can switch away, and the whole package can be removed later;
  • go:fix directives are not (yet) recognized by the gocheckcompilerdirectives linter,
    thus a a temporary exception in .golangci.yml.

Does this PR introduce a user-facing change?

NONE

@packit-as-a-service
Copy link
Copy Markdown

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@kolyshkin kolyshkin force-pushed the change-label branch 2 times, most recently from 42295d4 to d2f2af4 Compare May 21, 2026 21:30
@kolyshkin
Copy link
Copy Markdown
Contributor Author

New tests are not needed, there is no change in functionality. Can someone please add 'No New Tests' label?

@kolyshkin
Copy link
Copy Markdown
Contributor Author

New tests are not needed, there is no change in functionality. Can someone please add 'No New Tests' label?

..so that the rest of the tests can actually run

I was not able to find any external users of pkg/selinux but kept it
for now (and marked as deprecated) so we can remove it later.

PS pkg/selinux adds go:fix directives which are not (yet) recognized
by the gocheckcompilerdirectives linter, so add a temporary exception).

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin changed the title [DRAFT/DO NOT MERGE] bump selinux to v1.15.0, use ChangeLabelType bump selinux to v1.15.0, use SetProcessKind May 21, 2026
@kolyshkin kolyshkin marked this pull request as ready for review May 21, 2026 21:51
@kolyshkin
Copy link
Copy Markdown
Contributor Author

Can someone please add No New Tests?

@Luap99 Luap99 added the No New Tests Allow PR to proceed without adding regression tests label May 26, 2026
Copy link
Copy Markdown
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Luap99 Luap99 enabled auto-merge May 26, 2026 20:34
@Luap99
Copy link
Copy Markdown
Member

Luap99 commented May 28, 2026

something is wrong with cirrus here, please rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No New Tests Allow PR to proceed without adding regression tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants