specgen: move log_path handling over to the server#28800
Open
danishprakash wants to merge 1 commit into
Open
Conversation
Member
|
Sure. More sensible to set it here than it is on the client side. LGTM |
Member
|
Rebase should fix CI |
log_path is currently set at the client side and is ignored by the server in a remote session. This leads to either incorrect log_path being considered by the server or not honored at all. Move the handling from client to the server, in line with other flags such as log_driver. Signed-off-by: Danish Prakash <contact@danishpraka.sh>
danishprakash
force-pushed
the
remote-log-path
branch
from
b117262 to
cb4ef80
Compare
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
mheon
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
log_path is currently set at the client side and is ignored by the server in a remote session. This leads to either incorrect log_path being considered by the server or not honored at all. Move the handling from client to the server, in line with other flags such as log_driver.
Fixes #28792