Bump Buildah to v1.44.0#28805
Conversation
|
@mheon OK to add the bloat label to this? |
|
Done |
|
And LGTM for reference |
|
New cli options need to be integrated first, I really thought we had people doing these things ahead of time by now... |
|
Well, we did a preparatory vendor, but that was a few weeks back and a lot of stuff got merged into Buildah before the release happened. |
which is my point, we started a release without doing the prep vendor right before the release, which means we do not even know if this will pass podman CI technically |
3dba010 to
ed952a3
Compare
|
New options need to be fully wired in, cli, remote bindings and API... it is not just the docs that are missing. |
|
Taking a run at that in #28807. |
688a0de to
470a161
Compare
470a161 to
b83820d
Compare
|
Next Failure: Any Thoughts? I'm having trouble running the command locally as a non-root user, I think due to the changes in the conf files. |
Some query parameters were dropped at https://github.com/containers/podman/pull/28805/changes#diff-43fd97ffbb9420a1f310fa0f6a07e2c6ea1d4deb0eefc76ae13812102c11c65fL171 which probably shouldn't have been. |
I often have to prefix a command with |
|
Thanks @nalind, I'll re-add that block that was removed. That may indeed be it. |
b83820d to
10d0aa3
Compare
|
3 Failing tests, and a half dozen failing build tests. At least some I suspect are due to config file changes. For now, I've added a commit to skip them. |
73ae40e to
a97bd4d
Compare
Vendor in Buildah v1.44.0 in preparation for Podman v6.0 Signed-off-by: Tom Sweeney <tsweeney@redhat.com>
Add the various compression API calls as created by @nalind in containers#28807 Signed-off-by: Tom Sweeney <tsweeney@redhat.com>
Buildah v1.44.0 now uses --compression-format, --compression-level, and --force-compression options. Add these options to the build and farm man pages. Signed-off-by: Tom Sweeney <tsweeney@redhat.com>
Skip a number of failing tests. Issue containers#28810 Signed-off-by: Tom Sweeney <tsweeney@redhat.com>
a97bd4d to
8d036ce
Compare
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
|
I think the remainders are flakes. @lsm5 if you could eyeball, I'd appreciate it. |
Luap99
left a comment
There was a problem hiding this comment.
LGTM, I am concerned with the bunch of new test skips here though I agree lets get this landed first
Vendor in Buildah v1.44.0 in preparation for Podman v6.0
9 build tests had to be skipped to make this work. This is recorded in #28810 and we should circle back to tie them up.
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?