Skip to content

Bump Buildah to v1.44.0#28805

Merged
Luap99 merged 4 commits into
containers:mainfrom
TomSweeneyRedHat:dev/tsweeney/buildah-v1.44.0
May 29, 2026
Merged

Bump Buildah to v1.44.0#28805
Luap99 merged 4 commits into
containers:mainfrom
TomSweeneyRedHat:dev/tsweeney/buildah-v1.44.0

Conversation

@TomSweeneyRedHat
Copy link
Copy Markdown
Member

@TomSweeneyRedHat TomSweeneyRedHat commented May 27, 2026

Vendor in Buildah v1.44.0 in preparation for Podman v6.0

9 build tests had to be skipped to make this work. This is recorded in #28810 and we should circle back to tie them up.

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

None

@TomSweeneyRedHat TomSweeneyRedHat added the No New Tests Allow PR to proceed without adding regression tests label May 27, 2026
@TomSweeneyRedHat
Copy link
Copy Markdown
Member Author

@mheon OK to add the bloat label to this?

@mheon mheon added the bloat_approved Approve a PR in which binary file size grows by over 50k label May 28, 2026
@mheon
Copy link
Copy Markdown
Member

mheon commented May 28, 2026

Done

@mheon
Copy link
Copy Markdown
Member

mheon commented May 28, 2026

And LGTM for reference

@Luap99
Copy link
Copy Markdown
Member

Luap99 commented May 28, 2026

New cli options need to be integrated first, I really thought we had people doing these things ahead of time by now...

@mheon
Copy link
Copy Markdown
Member

mheon commented May 28, 2026

Well, we did a preparatory vendor, but that was a few weeks back and a lot of stuff got merged into Buildah before the release happened.

@Luap99
Copy link
Copy Markdown
Member

Luap99 commented May 28, 2026

Well, we did a preparatory vendor, but that was a few weeks back and a lot of stuff got merged into Buildah before the release happened.

which is my point, we started a release without doing the prep vendor right before the release, which means we do not even know if this will pass podman CI technically

@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/buildah-v1.44.0 branch from 3dba010 to ed952a3 Compare May 28, 2026 15:03
@Luap99
Copy link
Copy Markdown
Member

Luap99 commented May 28, 2026

New options need to be fully wired in, cli, remote bindings and API... it is not just the docs that are missing.
e.g. efba999

@nalind
Copy link
Copy Markdown
Member

nalind commented May 28, 2026

Taking a run at that in #28807.

@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/buildah-v1.44.0 branch 2 times, most recently from 688a0de to 470a161 Compare May 28, 2026 17:36
@github-actions github-actions Bot added the kind/api-change Change to remote API; merits scrutiny label May 28, 2026
@TomSweeneyRedHat
Copy link
Copy Markdown
Member Author

TomSweeneyRedHat commented May 28, 2026

I just very liberally stole from @nalind 's #22807 for the API calls and added another commit. TYVM @nalind!

@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/buildah-v1.44.0 branch from 470a161 to b83820d Compare May 28, 2026 18:03
@TomSweeneyRedHat
Copy link
Copy Markdown
Member Author

Next Failure:

5s] Summarizing 1 Failure:
[+1085s]   [FAIL] Podman UserNS support [It] podman build with --userns=auto
[+1085s]   /var/tmp/go/src/github.com/containers/podman/test/e2e/run_userns_test.go:66
[+1085s] 
[+1085s] Ran 2221 of 2498 Specs in 947.486 seconds

Any Thoughts?

I'm having trouble running the command locally as a non-root user, I think due to the changes in the conf files.

@nalind
Copy link
Copy Markdown
Member

nalind commented May 28, 2026

Next Failure:

5s] Summarizing 1 Failure:
[+1085s]   [FAIL] Podman UserNS support [It] podman build with --userns=auto
[+1085s]   /var/tmp/go/src/github.com/containers/podman/test/e2e/run_userns_test.go:66
[+1085s] 
[+1085s] Ran 2221 of 2498 Specs in 947.486 seconds

Any Thoughts?

Some query parameters were dropped at https://github.com/containers/podman/pull/28805/changes#diff-43fd97ffbb9420a1f310fa0f6a07e2c6ea1d4deb0eefc76ae13812102c11c65fL171 which probably shouldn't have been.

@nalind
Copy link
Copy Markdown
Member

nalind commented May 28, 2026

I'm having trouble running the command locally as a non-root user, I think due to the changes in the conf files.

I often have to prefix a command with env CONTAINERS_STORAGE_CONF=/dev/null to not pick up location settings from the older default system-wide configuration.

@TomSweeneyRedHat
Copy link
Copy Markdown
Member Author

Thanks @nalind, I'll re-add that block that was removed. That may indeed be it.

@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/buildah-v1.44.0 branch from b83820d to 10d0aa3 Compare May 29, 2026 00:08
@TomSweeneyRedHat
Copy link
Copy Markdown
Member Author

3 Failing tests, and a half dozen failing build tests. At least some I suspect are due to config file changes. For now, I've added a commit to skip them.

@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/buildah-v1.44.0 branch from 73ae40e to a97bd4d Compare May 29, 2026 02:51
Vendor in Buildah v1.44.0 in preparation for Podman v6.0

Signed-off-by: Tom Sweeney <tsweeney@redhat.com>
Add the various compression API calls as created by @nalind in containers#28807

Signed-off-by: Tom Sweeney <tsweeney@redhat.com>
Buildah v1.44.0 now uses --compression-format, --compression-level, and
--force-compression options.  Add these options to the build and farm
man pages.

Signed-off-by: Tom Sweeney <tsweeney@redhat.com>
Skip a number of failing tests.  Issue containers#28810

Signed-off-by: Tom Sweeney <tsweeney@redhat.com>
@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/buildah-v1.44.0 branch from a97bd4d to 8d036ce Compare May 29, 2026 13:14
@packit-as-a-service
Copy link
Copy Markdown

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@TomSweeneyRedHat
Copy link
Copy Markdown
Member Author

I think the remainders are flakes. @lsm5 if you could eyeball, I'd appreciate it.

Copy link
Copy Markdown
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I am concerned with the bunch of new test skips here though I agree lets get this landed first

@Luap99 Luap99 merged commit 0106d8f into containers:main May 29, 2026
86 of 88 checks passed
@TomSweeneyRedHat TomSweeneyRedHat deleted the dev/tsweeney/buildah-v1.44.0 branch May 29, 2026 17:34
@TomSweeneyRedHat
Copy link
Copy Markdown
Member Author

@Luap99 fwiw, I had created #28810 for the removed test and have added a note about it to the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bloat_approved Approve a PR in which binary file size grows by over 50k kind/api-change Change to remote API; merits scrutiny No New Tests Allow PR to proceed without adding regression tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants