Skip to content

Use GitHub token in Windows installer tests web request#28815

Merged
TomSweeneyRedHat merged 2 commits into
containers:mainfrom
l0rd:gh-token-for-webrequest
May 29, 2026
Merged

Use GitHub token in Windows installer tests web request#28815
TomSweeneyRedHat merged 2 commits into
containers:mainfrom
l0rd:gh-token-for-webrequest

Conversation

@l0rd
Copy link
Copy Markdown
Member

@l0rd l0rd commented May 29, 2026

This is to avoid requests failing due to GitHub's non-authenticated request rate limit.

See this PR check failure for an example of such a failure.

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

None

l0rd added 2 commits May 29, 2026 13:48
This is to avoid requests failing due to GitHub's non-authenticated
request rate limit.

See [this PR check
failure](https://github.com/podman-container-tools/podman-sandbox/actions/runs/26632208486/job/78483599334?pr=5)
for an example of such a failure.

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
@timcoding1988
Copy link
Copy Markdown
Collaborator

LGTM

Copy link
Copy Markdown
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomSweeneyRedHat
Copy link
Copy Markdown
Member

LGTM

@TomSweeneyRedHat
Copy link
Copy Markdown
Member

/lgtm

@TomSweeneyRedHat TomSweeneyRedHat merged commit 6ea0abf into containers:main May 29, 2026
86 of 87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants