Skip to content

Fix empty locale dropdown on step 2 for Drupal #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shradha-nahar merged 3 commits into from
May 8, 2026
Merged

Fix empty locale dropdown on step 2 for Drupal #1064

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ef19d1
fix: move drupal locale save API call before mapper creation to fix e…
yashin4112 May 8, 2026
64985d9
fix: null check added on config
yashin4112 May 8, 2026
0c3bf57
Merge branch 'dev' into bugfix/cmg-913
umesh-more-cstk May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 28 additions & 27 deletions upload-api/src/services/drupal/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,35 @@ const createDrupalMapper = async (

const localeData = await extractLocale(config);

// 🔧 CRITICAL: Always normalize to lowercase before saving
const localeArray = Array.from(localeData).map((locale: any) => {
const localeValue = typeof locale === 'string' ? locale : (locale?.code || locale?.value || locale);
return (localeValue || '').toLowerCase();
}).filter((locale: string) => locale && locale.length > 0);

const mapperConfig = {
method: 'post',
maxBodyLength: Infinity,
url: `${process.env.NODE_BACKEND_API}/v2/migration/localeMapper/${projectId}`,
headers: {
app_token,
'Content-Type': 'application/json'
},
data: {
locale: localeArray
}
};

const mapRes = await axios.request(mapperConfig);
if (mapRes?.status == 200) {
logger.info('Legacy CMS', {
status: HTTP_CODES?.OK,
message: HTTP_TEXTS?.LOCALE_SAVED
});
}

// Extract taxonomy vocabularies and save to drupalMigrationData
await extractTaxonomy(config.mysql);
await extractTaxonomy(config?.mysql);

const initialMapper = await createInitialMapper(config, affix);

Expand Down Expand Up @@ -79,32 +106,6 @@ const createDrupalMapper = async (
});
}

// 🔧 CRITICAL: Always normalize to lowercase before saving
const localeArray = Array.from(localeData).map((locale: any) => {
const localeValue = typeof locale === 'string' ? locale : (locale?.code || locale?.value || locale);
return (localeValue || '').toLowerCase();
}).filter((locale: string) => locale && locale.length > 0);

const mapperConfig = {
method: 'post',
maxBodyLength: Infinity,
url: `${process.env.NODE_BACKEND_API}/v2/migration/localeMapper/${projectId}`,
headers: {
app_token,
'Content-Type': 'application/json'
},
data: {
locale: localeArray
}
};

const mapRes = await axios.request(mapperConfig);
if (mapRes?.status == 200) {
logger.info('Legacy CMS', {
status: HTTP_CODES?.OK,
message: HTTP_TEXTS?.LOCALE_SAVED
});
}
} catch (err: any) {
logger.warn('Validation error:', {
status: HTTP_CODES?.UNAUTHORIZED,
Expand Down
Loading