You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@zhangcunli
Thank you for your great work.
Would you please add the case to test and make sure all tests are passed?
And we need to test that when size is increased, all old entries are preserved.
Modify the ringbuffer resize, ringbuffer_test.go:
////////////////////////////////////////////////////////////////////////////////////
ringbuf_test.go:28: [size:32, start:17, end:33, index:0]
ringbuf_test.go:29: ghibbbbccccefghi
size=16 --> size to 64 --> size to 32
Now ringbuffer index should be 16, we should not set the index to 0 and overwirte the ringbuffer;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add method Resize
newSize >= oldSize, keep all entry
newSie < oldSize, discard all entry;
bug, case: