Skip to content

[DRAFT] VideoPlayer#1903

Draft
analsituation wants to merge 5 commits intomasterfrom
feat/DS-11233
Draft

[DRAFT] VideoPlayer#1903
analsituation wants to merge 5 commits intomasterfrom
feat/DS-11233

Conversation

@analsituation
Copy link
Copy Markdown
Contributor

No description provided.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Sep 29, 2025

⚠️ No Changeset found

Latest commit: 22b644e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@analsituation
Copy link
Copy Markdown
Contributor Author

В файле development.mdx приблизительно накидал статус и дальнейший план действий.
Следующим этапом будет создание единого слоя для контролов в котором будут навешиваться события и для тач устройств и для десктопов с мышкой. Далее разделение на альбом/портрет. Далее реализация мини-плеера. Субтитры. И где-то там попутно тестирование и оптимизация.
Пока что много говнокода и промежуточных решений, оставляйте комментарии буду все фиксить

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 29, 2025

Pull Request Test Coverage Report for Build 18457386057

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.005%) to 79.7%

Files with Coverage Reduction New Missed Lines %
packages/date-time-input/src/utils/format.ts 1 89.32%
packages/plate/src/components/base-plate/Component.tsx 1 93.67%
packages/amount-input/src/Component.tsx 6 90.06%
Totals Coverage Status
Change from base Build 18091666361: 0.005%
Covered Lines: 9654
Relevant Lines: 11354

💛 - Coveralls

@analsituation
Copy link
Copy Markdown
Contributor Author

Кстати создал файл global.d.ts для импорта svg иконок, пока не все из них добавлены в айконпак. При этом если добавить global.d.ts в tsconfig то происходит ошибка на этапе коммита с просьбой перегенерить tsconfig и после генерации global.d.ts пропадает. Поэтому сейчас, например, в файле packages/video/src/components/controls/layers/common/bottom-controls/video-settings/index.tsx можно увидеть тайпскриптовую ошибку Cannot find module ... or its corresponding type declarations

@SiebenSieben SiebenSieben requested review from Oladii and removed request for Oladii December 22, 2025 09:15
@hextion hextion marked this pull request as draft December 23, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants