fix(base-modal): content height in Safari 26.1#2162
Open
mitrofanzxc wants to merge 1 commit intomasterfrom
Open
fix(base-modal): content height in Safari 26.1#2162mitrofanzxc wants to merge 1 commit intomasterfrom
mitrofanzxc wants to merge 1 commit intomasterfrom
Conversation
mitrofanzxc
requested review from
SiebenSieben,
dHIM24,
fulcanellee and
hextion
as code owners
🦋 Changeset detectedLatest commit: 08e35a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Coverage Report for CI Build 24082926206Coverage remained the same at 81.916%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Contributor
Demo build (default) |
Contributor
Demo build (alfasans) |
mitrofanzxc
force-pushed
the
feature/PORTALAPI-1029
branch
from
f881bcb to
08e35a2
Compare
hextion
reviewed
Apr 9, 2026
| Фикс для Safari 26.1: | ||
| Заменяем height: 100% на auto, чтобы контент не растягивался на весь экран. | ||
| */ | ||
| @supports (background: -webkit-named-image(apple-pay-logo-black)) { |
Collaborator
There was a problem hiding this comment.
@mitrofanzxc подскажи пож-та почему такое условие и какую проблему решаешь?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Исправление растягивания контента модального окна в Safari
В Safari 26.1 наблюдается баг рендеринга: при использовании height: 100% в классе .content компонента BaseModal, содержимое модального окна некорректно растягивалось на всю высоту экрана, если общая высота контента была значительной. В Google Chrome поведение оставалось корректным.
Что сделано:
Чек лист
Если есть визуальные изменения
Было:
Стало:
