Wallpaper zoom performance improvement and redrawing nodes#666
Open
mateodurante wants to merge 1 commit intocoreemu:developfrom
Open
Wallpaper zoom performance improvement and redrawing nodes#666mateodurante wants to merge 1 commit intocoreemu:developfrom
mateodurante wants to merge 1 commit intocoreemu:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a new logic for wallpaper drawing where first crop wallpaper showed piece and then scale to the canvas/view size, so it improves avoiding scale entire wallpaper that is so slow on large pictures or when you do a lot zoom in.
Its related to #659
Also I made a function redraw_nodes() called on zoom in and zoom out, to change position of interface name/ip/nodes.
PD: I have another improvement to avoid redraw at every event, but I'm going to open a discussion about that because maybe it can be made better.
Let me know if it is ok.
Thanks,
Mateo