feat: add toggle option to wait for node command to complete#925
Open
RuiCunhaM wants to merge 1 commit intocoreemu:developfrom
Open
feat: add toggle option to wait for node command to complete#925RuiCunhaM wants to merge 1 commit intocoreemu:developfrom
RuiCunhaM wants to merge 1 commit intocoreemu:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new option for node commands where we can choose to wait, or not, for the command to complete. It fixes #924 allowing to start GUI applications like Wireshark without blocking the core's GUI.
The default behavior is to wait for completion in order to keep compatibility with previous versions.
Furthermore, I overrode the from_yaml method in NodeCommand to deal with existent configurations that do not have a "wait" value defined. In future versions, if this it no longer a problem, this method can be removed.