cmd-import: add an ending newline to json files #4403
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our whitespace checker [1] will complain if there are newlines at the end of files and since we are now copying the generated lockfiles into the src/config repo in bump-lockfile [2] the whitespace checker is complaining about it. json.dump() itself doesn't add a newline because it isn't required to [3]. Let's just explicitly do it here. [1] https://github.com/coreos/repo-templates/blob/5386c91f3f4b8f81009997efecf28b24cc8597a0/find-whitespace/script.sh#L27-L40 [2] coreos/fedora-coreos-pipeline@0029f12 [3] https://stackoverflow.com/questions/54716132/why-is-json-dump-not-ending-the-line-with-n
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a trailing newline to JSON files generated by cmd-import. The changes are correct, but could be improved. For consistency, meta.json generated in finalize_build (line 234) should also get a trailing newline. Also, the logic for writing JSON files with a newline is duplicated; I've left a comment suggesting a refactoring to a helper function to improve maintainability.
Nemric
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our whitespace checker [1] will complain if there are newlines at the end of files and since we are now copying the generated lockfiles into the src/config repo in bump-lockfile [2] the whitespace checker is complaining about it.
json.dump() itself doesn't add a newline because it isn't required to [3]. Let's just explicitly do it here.
[1] https://github.com/coreos/repo-templates/blob/5386c91f3f4b8f81009997efecf28b24cc8597a0/find-whitespace/script.sh#L27-L40
[2] coreos/fedora-coreos-pipeline@0029f12
[3] https://stackoverflow.com/questions/54716132/why-is-json-dump-not-ending-the-line-with-n