Skip to content
This repository was archived by the owner on Feb 5, 2020. It is now read-only.

Update onboard-service-account.md #13

Open
robszumski wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update onboard-service-account.md #13

robszumski wants to merge 1 commit into from

Conversation

@robszumski
Copy link
Member

@robszumski robszumski commented Sep 11, 2017

Fixes change in etcd cluster name related to coreos/tectonic-installer#1876

@hongchaodeng
Copy link

hongchaodeng commented Sep 11, 2017

ref: https://github.com/coreos/etcd-operator/blob/master/doc/user/rbac.md#production-setup

hongchaodeng
hongchaodeng reviewed Sep 11, 2017
View reviewed changes
Documentation/admin/onboard-service-account.md
name: etcd-operator
rules:
- apiGroups:
- etcd.coreos.com
Copy link

@hongchaodeng hongchaodeng Sep 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

etcd.database.coreos.com

@hongchaodeng
Copy link

hongchaodeng commented Sep 11, 2017

Also need to change TPR to

- apiGroups:
  - apiextensions.k8s.io
  resources:
  - customresourcedefinitions
  verbs:
  - "*"

@joshix joshix mentioned this pull request Oct 11, 2017
Merged
@robszumski
Copy link
Member Author

robszumski commented Feb 9, 2018

@hongchaodeng do you know if this is still a needed change?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@hongchaodeng hongchaodeng hongchaodeng left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robszumski @hongchaodeng