Fixes issue with matrix derivation where output for sector is negative for DC model#16
Closed
WesIngwersen wants to merge 1 commit intodevelopfrom
Closed
Fixes issue with matrix derivation where output for sector is negative for DC model#16WesIngwersen wants to merge 1 commit intodevelopfrom
WesIngwersen wants to merge 1 commit intodevelopfrom
Conversation
…h itself and it's output to 0.001 when the output is 0, also do this adjustment when output is negative before trying to invert the output vector
Author
|
FYI see the CI check failure here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will resolve #15. Addressed with model
DCEEIOv1.3-pecan-22built from the generic pecan specSetting a close to zero negative value for commodity output to 0.001 permits the DC model to build for 2022 where it previously failed. However there are a number of outstanding issues with validation test failures. Because of this it would not be recommended to use this model for most purposes, but that is beyond the scope of this PR.
The more important question is if this change to
normalizeIOTransactionsis acceptable or if there is ever any case where output should be negative and not adjusted.