Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the cached collection resolver to avoid returning stale cached errors and adds/adjusts tests around concurrent resolution, invalidation, and recovery after failures.
Changes:
- Track the timestamp of the last failed resolution (
ResolvedAt) and use it to decide when to retry after errors. - Modify resolver thread cleanup behavior (including slow-map entry deletion) and adjust slow-path control flow.
- Add/restore tests for double invalidation and recovery after a resolution error; adjust an existing concurrency/error test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| collectionresolver_cached.go | Adds ResolvedAt and new retry/cleanup logic intended to support recovery after errors and prevent stale-error returns. |
| collectionresolver_cached_test.go | Adds concurrency controls and new tests for invalidation and error recovery, plus timing-based ordering to exercise the new logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Westwooo
previously approved these changes
Feb 24, 2026
brett19
force-pushed
the
ING-1428_collection-resolver-loop
branch
from
b2a6e4f to
03e57a7
Compare
brett19
force-pushed
the
ING-1428_collection-resolver-loop
branch
from
03e57a7 to
dd17135
Compare
Westwooo
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.