Stop counting unused appdata#4062
Merged
MartinquaXD merged 1 commit intomainfrom Jan 19, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the logic for counting unused appdata entries, which was identified as a source of significant database load. The changes are straightforward and effectively eliminate an expensive, unused query. By removing the count_unused_app_data function and the associated unused_app_data metric, this PR provides a clean and beneficial performance optimization. The code removal is complete and I found no issues with the implementation.
squadgazzz
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
According to RDS metrics a relatively high amount of DB load gets caused by a query counting how many appdatas have never been used in an order.
This query takes ~4s on the read replica. While I originally worked on speeding up the query (a simple index produced good results) I think it probably makes more sense to remove this logic altogether.
We've never paid attention to this metric so why pay with DB load for something we don't use?
Changes
Dropped code to count unused appdatas in the DB metrics.