Discard zero out amount quote solutions #4072
Merged
+10
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request effectively addresses the issue of zero out amount quote solutions by discarding them during the price competition. This is a sound approach that prevents misleading results and aligns with the stated goal of returning a 'NoLiquidity' error in such cases. The changes improve the robustness and clarity of the price estimation logic.
jmg-duarte
approved these changes
Jan 20, 2026
fafk
approved these changes
Jan 21, 2026
MartinquaXD
approved these changes
Jan 21, 2026
Contributor
|
Reminder to close #3975 when this gets merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As an alternative to #3975, this PR proposes an alternative solution, where instead of introducing a new error, which is not really useful for the end user, just discard zero out amount solutions during the quote competition. The API will return a
NoLiquidityerror in that case.