fix: add 5 missing test files to MANIFEST#382
Draft
Koan-Bot wants to merge 4 commits intocpan-authors:mainfrom
Draft
fix: add 5 missing test files to MANIFEST#382Koan-Bot wants to merge 4 commits intocpan-authors:mainfrom
Koan-Bot wants to merge 4 commits intocpan-authors:mainfrom
Conversation
t/binmode.t, t/fttext_ftbinary.t, t/open_pipe_mode.t, t/open_pipe_mode_strict.t, and t/readline_line_number.t were tracked in git but missing from MANIFEST, so they would not ship in the CPAN tarball. Also add .claude/ to MANIFEST.SKIP to suppress filecheck noise. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Test::CheckManifest has a known bug (reneeb/Test-CheckManifest#20) so the manifest test was permanently skipped. Replace it with ExtUtils::Manifest's manicheck/filecheck which are core modules and work reliably. Keeps the RELEASE_TESTING guard. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ExtUtils::Manifest uses File::Find which calls chdir — this fails under taint mode (-T) with "Insecure dependency in chdir". The old Test::CheckManifest-based test had -T but never ran (was skip_all'd). Now that the test actually runs, drop the taint flag. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The `is(...) or diag(...) for @array` pattern was parsed as a loop — when the array was empty, the is() assertion never executed, producing 0 tests. Test::More with done_testing() and 0 tests outputs `1..0` which the harness interprets as skip, followed by exit 255. Separate the is() and diag() so is() always runs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add 5 test files to MANIFEST that were tracked in git but missing from the distribution.
Why
These tests won't be included in the CPAN tarball without MANIFEST entries, so
make testfrom a CPAN install skips them silently.How
t/binmode.t,t/fttext_ftbinary.t,t/open_pipe_mode.t,t/open_pipe_mode_strict.t,t/readline_line_number.t.claude/to MANIFEST.SKIP to suppress filecheck warningsTesting
manicheck()andfilecheck()both return clean after the fix.🤖 Generated with Claude Code